Change setting's deprecation message wording #80900
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depending on whether a message is critical or warning a message shoudl indicate to check breaking changes documentation (critical level) or deprecation changes documentation (warn level) relates elastic#79666
Contributor
Author
|
ok to test |
Contributor
Author
|
@elasticmachine update branch |
…ka/elasticsearch into settings_breaking_changes_warning
nik9000
added
:Core/Infra/Settings
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Contributor
|
@pgomulka This looks like an older PR, but the change looks good to me. Have we decided if we wanted to proceed with this change? It appears that few other tests need to be adjusted. |
Contributor
|
As discussed, closing to be revisited for v9 (#107639) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depending on whether a message is critical or warning a message should
indicate to check breaking changes documentation (critical level) or
deprecation changes documentation (warn level)
relates #79666