-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Change data streams from being a xpack module to be a normal module. #83391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 17 commits into
elastic:master
from
martijnvg:move_data_streams_to_modules
Feb 2, 2022
Merged
Change data streams from being a xpack module to be a normal module. #83391
elasticsearchmachine
merged 17 commits into
elastic:master
from
martijnvg:move_data_streams_to_modules
Feb 2, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the data stream actions to the server module The data stream info and usage actions were moved to the xpack core project, because the info and usage infrastructure only exists in xpack.
(SocketPermission)
* Move xpack related yaml tests back to xpack. * Move info and usage related rest tests to xpack core module * Move yaml tests to data stream module * Move all qa tests to regular java rest tests inside data stream module
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
danhermann
approved these changes
Feb 2, 2022
Contributor
danhermann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Data Management/Data streams
Data streams and their lifecycles
>refactoring
Team:Data Management
Meta label for data/management team
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the data stream actions to the server module and moves the data streams module from
./x-pack/plugin/to./modules/The data stream info and usage actions were moved to the xpack core project,
because the info and usage infrastructure only exists in xpack.
Also the qa module is replaced by
yamlRestTestandjavaRestTestdirectories.The multi node qa test didn't really test multi node capabilities, so that was removed.
(The only test in this module tested data stream info and usage features)