Place index_mode field behind feature flag. #83650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that `index_mode` field in data stream template is behind `es.index_mode_feature_flag_registered` feature flag. This was not the case.
martijnvg
added
>non-issue
:Data Management/Data streams
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
martijnvg
commented
Feb 8, 2022
modules/data-streams/build.gradle
Outdated
| tasks.named("yamlRestTest").configure{enabled = false } | ||
| } | ||
|
|
||
| if (BuildParams.isSnapshotBuild() == false) { |
Member
Author
There was a problem hiding this comment.
This should have been added via #83391, but didn't label that pr with release-test label.
Member
Author
|
I'm fixing the the release build before this pr in #83720. Changes not related to this change should be merged in first to fix the release build. |
imotov
approved these changes
Feb 9, 2022
Contributor
imotov
left a comment
imotov
left a comment
There was a problem hiding this comment.
Looks like we need to hunt down and add systemProperty 'es.index_mode_feature_flag_registered', 'true' to a few other builds. But the rest LGTM.
Member
Author
|
@elasticmachine run elasticsearch-ci/bwc |
martijnvg
added
auto-backport
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Feb 10, 2022
Ensure that `index_mode` field in data stream template is behind `es.index_mode_feature_flag_registered` feature flag. This was not the case.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
index_modefield in data stream template is behindes.index_mode_feature_flag_registeredfeature flag.This was not the case and and using this would cause errors, because large part of tsdb is currently behind feature flag.
This isn't a bug yet, because 8.1.0 hasn't been released yet.