Revert to 1 node cluster for YAML tests and avoid wait for green #94385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxsalehi
added
>test
elasticsearchmachine
added
v8.8.0
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
approved these changes
Mar 8, 2023
Member
Author
|
@elasticmachine update branch |
pxsalehi
added
the
auto-merge-without-approval
Member
Author
|
(@mark-vieira FYI, I've reverted the changes to the YAML test cluster size.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reviewed the tests that motivated the use of a two node cluster for the YAML tests. It seems there is no reason anymore to use
wait_for_status: greenandnumber_of_replicas: 0since the default values make sure the write will succeed. There are many newer YAML tests where an index creation is followed by an index operation, w/o waiting for green. With this PR, I'm reverting the changes in #94304, and instead modify the tests.