-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Further unblocking of recovery #95270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further unblocking of recovery #95270
Conversation
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
I hope that this is easy enough to review as a sequence of individual commits (ignoring whitespace changes). If not I can make a sequence of PRs. Note that after these changes the only blocking during recovery happens at relocation handoff when waiting for all ongoing operations to finish. I hope to fix that soon too, but it's a more involved change because the blocking is deep within |
|
Marking this as WIP because this simple approach doesn't quite work, see #95309. |
914d522 to
897e9a2
Compare
897e9a2 to
93d672a
Compare
|
Ok this is good to review now |
henningandersen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for splitting it up into individual commits, made it an easy review.
`IndexShard#markAllocationIdAsInSync` is interruptible because it may block the thread on a monitor waiting for the local checkpoint to advance, but we lost the ability to interrupt it on a recovery cancellation in elastic#95270. Closes elastic#96578 Closes elastic#100589
`IndexShard#markAllocationIdAsInSync` is interruptible because it may block the thread on a monitor waiting for the local checkpoint to advance, but we lost the ability to interrupt it on a recovery cancellation in elastic#95270. Closes elastic#96578 Closes elastic#100589
Follow-on from #95115 using the new async
runUnderPrimaryPermitto remove almost all the remaining blocking inRecoverySourceHandler.