Disable auto-creation of indices in the AnalyticsEventEmitter (#95880) #95890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c#95880) The analytics event emitter delegates the posted events to a bulk processor. When deleting the analytics collection, there's no guarantee that some events are still in flight. This change ensures that these events cannot re-create the underlying index after its deletion. Closes elastic#95629 Closes elastic#95657 Closes elastic#95686 Closes elastic#95717
jimczi
added
>test
jimczi
requested review from
afoucret,
carlosdelest and
joemcelroy
and removed request for
afoucret
joemcelroy
approved these changes
May 5, 2023
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
May 10, 2023
The previous fix (elastic#95890) that relied on an alias couldn't work since we're not using an explicit alias to index documents. We don't have any test that checks if the events are correctly indexed so I had to manually check this change. I also had to use 8.8 since the feature is in broken state in main due to elastic#95917. I am opening this PR as a quick fix for 8.8.x and will open another one to add explicit tests for the indexation.
jimczi
added a commit
that referenced
this pull request
May 10, 2023
…6001) The previous fix (#95890) that relied on an alias couldn't work since we're not using an explicit alias to index documents. We don't have any test that checks if the events are correctly indexed so I had to manually check this change. I also had to use 8.8 since the feature is in broken state in main due to #95917. I am opening this PR as a quick fix for 8.8.x and will open another one to add explicit tests for the indexation.
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
May 10, 2023
…astic#96001) The previous fix (elastic#95890) that relied on an alias couldn't work since we're not using an explicit alias to index documents. We don't have any test that checks if the events are correctly indexed so I had to manually check this change. I also had to use 8.8 since the feature is in broken state in main due to elastic#95917. I am opening this PR as a quick fix for 8.8.x and will open another one to add explicit tests for the indexation.
jimczi
added a commit
that referenced
this pull request
May 10, 2023
…6001) (#96005) The previous fix (#95890) that relied on an alias couldn't work since we're not using an explicit alias to index documents. We don't have any test that checks if the events are correctly indexed so I had to manually check this change. I also had to use 8.8 since the feature is in broken state in main due to #95917. I am opening this PR as a quick fix for 8.8.x and will open another one to add explicit tests for the indexation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #95880