Skip to content

Disable auto-creation of indices in the AnalyticsEventEmitter (#95880) #95890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2023
Merged

Disable auto-creation of indices in the AnalyticsEventEmitter (#95880) #95890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .../src/yamlRestTest/resources/rest-api-spec/test/entsearch/60_behavioral_analytics_list.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
setup:
- skip:
version: "all"
reason: "@AwaitsFix https://github.com/elastic/elasticsearch/issues/95717"

- do:
search_application.put_behavioral_analytics:
name: my-test-analytics-collection
Expand All @@ -16,7 +12,10 @@ teardown:
- do:
search_application.delete_behavioral_analytics:
name: my-test-analytics-collection
ignore: 404

- do:
search_application.delete_behavioral_analytics:
name: my-test-analytics-collection2

---
"Get Analytics Collection for a particular collection":
Expand Down
1 change: 0 additions & 1 deletion ...t/src/yamlRestTest/resources/rest-api-spec/test/entsearch/70_behavioral_analytics_put.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ teardown:
- do:
search_application.delete_behavioral_analytics:
name: test-analytics-collection
ignore: 404

---
"Create Analytics Collection":
Expand Down
5 changes: 0 additions & 5 deletions ...amlRestTest/resources/rest-api-spec/test/entsearch/90_behavioral_analytics_event_post.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
setup:
- skip:
version: "all"
reason: "@AwaitsFix https://github.com/elastic/elasticsearch/issues/95686"

- do:
search_application.put_behavioral_analytics:
name: my-test-analytics-collection
Expand All @@ -12,7 +8,6 @@ teardown:
- do:
search_application.delete_behavioral_analytics:
name: my-test-analytics-collection
ignore: 404


# Page view event tests #########################################
Expand Down
2 changes: 2 additions & 0 deletions ...main/java/org/elasticsearch/xpack/application/analytics/ingest/AnalyticsEventEmitter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ private IndexRequest createIndexRequest(AnalyticsEvent event) throws IOException

try (XContentBuilder builder = JsonXContent.contentBuilder()) {
return client.prepareIndex(collection.getEventDataStream())
// disable auto-creation of the underlying index
.setRequireAlias(true)
.setCreate(true)
.setSource(event.toXContent(builder, ToXContent.EMPTY_PARAMS))
.request();
Expand Down