[Profiling] Don't map new fields by default #96876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we set the mapping parameter `dynamic` to `false` for all profiling-related indices / index templates. Previously we were relying on the default behavior which would have mapped new fields dynamically. This is problematic for schema evolution. With this change we will still accept documents with additional fields but they will not be automatically added to the mappings.
danielmitterdorfer
added
>non-issue
:UniversalProfiling/Application
Collaborator
|
Pinging @elastic/profiling (Team:Universal Profiling) |
christos68k
reviewed
Jun 15, 2023
| "_source": { | ||
| "enabled": false | ||
| }, | ||
| "dynamic": false, |
Member
There was a problem hiding this comment.
Metrics are dynamically mapped currently, so if we switch this we'd also need to modify the mapping to explicitly add them.
Member
Author
There was a problem hiding this comment.
As discussed offline let's make an exception for profiling-metrics as the current mapping makes sense and it's a datastream, meaning that old data would age eventually anyway. I'll revert the change for this file.
athre0z
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we set the mapping parameter
dynamictofalsefor all profiling-related indices / index templates. Previously we were relying on the default behavior which would have mapped new fields dynamically. This is problematic for schema evolution. With this change we will still accept documents with additional fields but they will not be automatically added to the mappings.