Skip to content

[Profiling] Don't map new fields by default #96876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2023
Merged

[Profiling] Don't map new fields by default #96876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
822a6af
[Profiling] Ignore new mapping fields by default
danielmitterdorfer Jun 15, 2023
fa15b6e
Keep dynamic mappings for profiling-metrics
danielmitterdorfer Jun 15, 2023
a7f3cfb
Be explicit about dynamic setting of metrics
danielmitterdorfer Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .../main/resources/org/elasticsearch/xpack/profiler/component-template/profiling-events.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
"_source": {
"enabled": false
},
"dynamic": false,
"properties": {
"ecs.version": {
"type": "keyword",
Expand Down
1 change: 1 addition & 0 deletions .../resources/org/elasticsearch/xpack/profiler/component-template/profiling-executables.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"_source": {
"mode": "synthetic"
},
"dynamic": false,
"properties": {
"ecs.version": {
"type": "keyword",
Expand Down
5 changes: 1 addition & 4 deletions ...c/main/resources/org/elasticsearch/xpack/profiler/component-template/profiling-hosts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"_source": {
"enabled": true
},
"dynamic": false,
"properties": {
"ecs.version": {
"type": "keyword"
Expand All @@ -31,7 +32,6 @@
"format": "epoch_second"
},
"profiling": {
"dynamic": false,
"properties": {
"project.id": {
"type": "keyword"
Expand Down Expand Up @@ -160,7 +160,6 @@
}
},
"ec2": {
"dynamic": false,
"properties": {
"ami_id": {
"type": "keyword"
Expand Down Expand Up @@ -224,7 +223,6 @@
}
},
"azure": {
"dynamic": false,
"properties": {
"compute.sku": {
"type": "keyword"
Expand Down Expand Up @@ -268,7 +266,6 @@
}
},
"gce": {
"dynamic": false,
"properties": {
"instance.id": {
"type": "keyword"
Expand Down
6 changes: 6 additions & 0 deletions ...main/resources/org/elasticsearch/xpack/profiler/component-template/profiling-metrics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@
"_source": {
"enabled": false
},
/*
We intentionally allow dynamic mappings for metrics. Which metrics are added is guarded by
the collector and we want to allow adding new metrics over time. As this is a datastream,
which will age and eventually be deleted, schema evolution is not a major concern here.
*/
"dynamic": true,
"properties": {
"ecs.version": {
"type": "keyword",
Expand Down
1 change: 1 addition & 0 deletions .../resources/org/elasticsearch/xpack/profiler/component-template/profiling-stackframes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"_source": {
"enabled": true
},
"dynamic": false,
"properties": {
"ecs.version": {
"type": "keyword",
Expand Down
1 change: 1 addition & 0 deletions .../resources/org/elasticsearch/xpack/profiler/component-template/profiling-stacktraces.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"_source": {
"mode": "synthetic"
},
"dynamic": false,
"properties": {
"ecs.version": {
"type": "keyword",
Expand Down
1 change: 1 addition & 0 deletions ...main/resources/org/elasticsearch/xpack/profiler/component-template/profiling-symbols.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"_source": {
"enabled": true
},
"dynamic": false,
"properties": {
"ecs.version": {
"type": "keyword",
Expand Down
1 change: 1 addition & 0 deletions ...sources/org/elasticsearch/xpack/profiler/index-template/profiling-returnpads-private.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"_source": {
"enabled": true
},
"dynamic": false,
"properties": {
"ecs.version": {
"type": "keyword",
Expand Down
1 change: 1 addition & 0 deletions ...n/resources/org/elasticsearch/xpack/profiler/index-template/profiling-sq-executables.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"_source": {
"mode": "synthetic"
},
"dynamic": false,
"properties": {
"ecs.version": {
"type": "keyword",
Expand Down
1 change: 1 addition & 0 deletions ...in/resources/org/elasticsearch/xpack/profiler/index-template/profiling-sq-leafframes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"_source": {
"mode": "synthetic"
},
"dynamic": false,
"properties": {
"ecs.version": {
"type": "keyword",
Expand Down