Do not use auto_expand_replica in mget yaml rest tests #97427
Conversation
pxsalehi
added
>test
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
|
||
| - do: | ||
| cluster.health: | ||
| wait_for_status: green |
There was a problem hiding this comment.
Is it safe to completely remove this section? Should we at least wait for yellow?
There was a problem hiding this comment.
Seems to be safe. For some of the tests changed here and in my PR linked above, the original test didn't even have the wait, see e.g. https://github.com/elastic/elasticsearch/blob/8.8/rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/mget/40_routing.yml#L47-L64.
The get tests use this setup and they seem to be ok. The writes would have to wait I think anyway. See the comment of this commit 5010402.
|
@elasticmachine run elasticsearch-ci/part-1 There were no test failures, but somehow the Jenkins job failed. |
|
@elasticmachine update branch |
pxsalehi
added
the
auto-merge-without-approval
💚 Backport successful
|
As described in the issue, the change in elastic#96763 has made the MixedClusterClientYamlTestSuiteIT for mget fail very often. For now, let's take the same approach that we have for get. Closes elastic#97236
5 participants
As described in the issue, the change in #96763
has made the MixedClusterClientYamlTestSuiteIT for
mgetfail veryoften. For now, let's take the same approach that we have for
get.Closes #97236