Skip to content

Do not use auto_expand_replica in mget yaml rest tests #97427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Do not use auto_expand_replica in mget yaml rest tests #97427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4068fc2
Do not use auto_expand_replica in mget yaml rest tests
pxsalehi Jul 6, 2023
f3b19af
Merge branch 'main' into ps230706-fixTest-mgetYamlRestMixedCluster
elasticmachine Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/mget/40_routing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@ routing:
index:
number_of_shards: 5
number_of_routing_shards: 5
auto_expand_replicas: 0-1

- do:
cluster.health:
wait_for_status: green
Copy link
Contributor

@idegtiarenko idegtiarenko Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to completely remove this section? Should we at least wait for yellow?

Copy link
Member Author

@pxsalehi pxsalehi Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be safe. For some of the tests changed here and in my PR linked above, the original test didn't even have the wait, see e.g. https://github.com/elastic/elasticsearch/blob/8.8/rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/mget/40_routing.yml#L47-L64.

The get tests use this setup and they seem to be ok. The writes would have to wait I think anyway. See the comment of this commit 5010402.


- do:
index:
Expand Down Expand Up @@ -51,15 +46,10 @@ requires routing:
settings:
index:
number_of_shards: 5
auto_expand_replicas: 0-1
mappings:
_routing:
required: true

- do:
cluster.health:
wait_for_status: green

- do:
index:
index: test_1
Expand Down
5 changes: 0 additions & 5 deletions rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/mget/60_realtime_refresh.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@
settings:
index:
refresh_interval: -1
auto_expand_replicas: 0-1

- do:
cluster.health:
wait_for_status: green

- do:
index:
Expand Down