Skip to content

feat: Support METRICS_INFO in AST & APIs#49

Merged
momovdg merged 2 commits into
mainfrom
esql-metrics-info
Mar 10, 2026
Merged

feat: Support METRICS_INFO in AST & APIs#49
momovdg merged 2 commits into
mainfrom
esql-metrics-info

Conversation

@momovdg
Copy link
Copy Markdown
Contributor

@momovdg momovdg commented Mar 6, 2026 •
edited
Loading

part of: elastic/kibana#255433

Summary

This PR adds AST support for the new METRICS_INFO command as well as support in the visitor API

Details

  • cast_to_ast_converter: just creates the command with the context since the grammar is just:
metricsInfoCommand
    : METRICS_INFO
    ;
  • global_visitor_context: adds the visitMetricsInfoCommand in the same way as the other commands along with its types.

Checklist

  • Unit tests have been added or updated.
  • The PR title has the correct conventional commit label in the title, this is crucial for the correct versioning of this package. Check the following cheat shit.
    Title Label Release
    breaking: true (!) major
    feat minor
    fix patch
    refactor patch
    perf patch
    build patch
    docs patch
    chore patch
    revert patch

@momovdg momovdg self-assigned this Mar 6, 2026
@momovdg momovdg force-pushed the esql-metrics-info branch from 901951f to 3f3c20c Compare March 9, 2026 10:30
@momovdg momovdg force-pushed the esql-metrics-info branch from 3f3c20c to 3a75850 Compare March 10, 2026 10:43
@momovdg momovdg marked this pull request as ready for review March 10, 2026 11:36
@momovdg momovdg requested a review from a team as a code owner March 10, 2026 11:36
stratoula
stratoula approved these changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👏

@bartoval bartoval mentioned this pull request Mar 10, 2026
Merged
@momovdg momovdg merged commit 667cdc1 into main Mar 10, 2026
3 checks passed
@momovdg momovdg deleted the esql-metrics-info branch March 10, 2026 12:21
bartoval added a commit that referenced this pull request Mar 10, 2026
@bartoval
feat: Add ts info command (#53)
631704f 
## Summary

Part of elastic/kibana#256614

Same of #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

@momovdg momovdg

Labels

v9.4-kibana

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@momovdg @stratoula