Add basic typings for Flyout#1001
Merged
stacey-gammon merged 4 commits intoJul 11, 2018
Merged
Conversation
timroes
reviewed
Jul 11, 2018
| @@ -0,0 +1,3 @@ | |||
| declare module '@elastic/eui' { | |||
| export const EuiFlyout: React.SFC<any>; | |||
Contributor
There was a problem hiding this comment.
If we put it into EUI, should we rather also properly type the Properties here?
Author
There was a problem hiding this comment.
ohhhh alright alright. :) Typings expanded.
stacey-gammon
force-pushed
the
2018-07-11-typescript-flyout
branch
from
9c17f8d to
7ef218d
Compare
stacey-gammon
force-pushed
the
2018-07-11-typescript-flyout
branch
from
587dd27 to
2d03f5e
Compare
timroes
reviewed
Jul 11, 2018
| declare module '@elastic/eui' { | ||
| export interface EuiFlyoutProps { | ||
| onClose: () => void; | ||
| size: 's' | 'm' | 'l'; |
Contributor
There was a problem hiding this comment.
I think that typing might be wrong. Is size really a mandatory property? If not it should be marked as optional size? in the property interface.
Author
There was a problem hiding this comment.
fixed here: https://github.com/elastic/eui/pull/1003/files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Then we can get rid of stuff like this: https://github.com/elastic/kibana/pull/20163/files#diff-e90413d01eed523422d8446b072e6f7eR26
cc @timroes