Fix context menu focus jumping#1018
Merged
Merged
Conversation
Contributor
Author
|
Hmm. Hold on this. Committed to fast. |
updated a single test to be async
Contributor
Author
|
OK @chandlerprall, tests pass now. Thanks for your help 🙌 |
chandlerprall
approved these changes
Jul 16, 2018
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Code LGTM, docs ran fine
Contributor
Author
|
cc @peteharverson who asked about this one over slack. This will likely go into a 3.0.1 release and we'll make sure it gets in for 6.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #959
Adds an animationFrame delay on the updateFocus function for context menus. This gives it enough time for the positioning to calculate first.