Assign EuiComboBox data-test-subj to the options list with a '-optionsList' suffix#1054
Conversation
cjcenizal
added
the
breaking change
cjcenizal
force-pushed
the
combo-box-list-test
branch
from
f24f59e to
4785b84
Compare
|
|
||
| **Breaking changes** | ||
|
|
||
| - `EuiComboBox` now applies the provided `data-test-subj` to its options list element with the suffix `-optionsList` so you can find a specific combo box instance's options list. This wasn't previously possible because the options list is attached to the body element, not the combo box element. This is a break from the previous `data-test-subj` which was simply `comboBoxOptionsList`. ([#1054](https://github.com/elastic/eui/pull/1054)) |
There was a problem hiding this comment.
I don't see this as a breaking change?
There was a problem hiding this comment.
Kibana has tests which rely on the data-test-subj="comboBoxOptionsList" selector, and they'll break once we intake this change.
There was a problem hiding this comment.
I tried to find that line in the PR, but couldn't (sorry). Can that attribute be left in place and just add the one for individual options?
There was a problem hiding this comment.
Good idea! I'll make that change.
|
@chandlerprall Thanks, done. |
|
@cjcenizal Thanks. I'll fix. |
|
@cjcenizal err, I mean, thanks for fixing. |
|
|
||
| ## [`3.2.1`](https://github.com/elastic/eui/tree/v3.2.1) | ||
|
|
||
| - `EuiComboBox` now applies the provided `data-test-subj` to its options list element with the suffix `-optionsList` so you can find a specific combo box instance's options list. This wasn't previously possible because the options list is attached to the body element, not the combo box element. This is in addition to the existing `data-test-subj="comboBoxOptionsList"`. ([#1054](https://github.com/elastic/eui/pull/1054)) |
There was a problem hiding this comment.
This should be under master and labeled as a breaking change.
There was a problem hiding this comment.
not a breaking change, this is now only adding new attributes without removing the old one (but yes, under master)
chandlerprall
removed
the
breaking change
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
lgtm
code review, inspected dom to view new data-test-subj attributes
4 participants
This is so you can find a specific combo box instance's options list. This wasn't previously possible because the options list is attached to the body element, not the combo box element.