Skip to content

Add resize-observer-polyfill as a dependency#1085

Merged
markov00 merged 2 commits into
elastic:masterfrom
markov00:fix/1084-resize-observer-dep
Aug 3, 2018
Merged

Add resize-observer-polyfill as a dependency#1085
markov00 merged 2 commits into
elastic:masterfrom
markov00:fix/1084-resize-observer-dep

Conversation

@markov00
Copy link
Copy Markdown
Contributor

@markov00 markov00 commented Aug 3, 2018

Fix #1084 Add the resize-observer-polyfill as a dependency, previously was a devDependency and causes missing dependency error.

cchaos
cchaos approved these changes Aug 3, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

chandlerprall
chandlerprall approved these changes Aug 3, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@markov00 markov00 merged commit 4b535c2 into elastic:master Aug 3, 2018
@markov00 markov00 deleted the fix/1084-resize-observer-dep branch August 3, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

@cchaos cchaos cchaos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markov00 @chandlerprall @cchaos