Skip to content

Added more css text utilities#1092

Merged
cchaos merged 4 commits into
elastic:masterfrom
cchaos:break-normal
Aug 7, 2018
Merged

Added more css text utilities#1092
cchaos merged 4 commits into
elastic:masterfrom
cchaos:break-normal

Conversation

@cchaos
Copy link
Copy Markdown
Contributor

@cchaos cchaos commented Aug 7, 2018

  • Moved properties from .eui-textTruncate into a mixin and including that mixin in the utility class
  • Added .eui-textBreakNormal in case consumers need to override a applied word-break: break-all
  • Using the above class on props doc table contents to fix Set nowrap on props definitions #678

screen shot 2018-08-07 at 12 12 33 pm

- Moved properties from `.eui-textTruncate` into a mixin and including that mixin in the utility class
- Added `.eui-textBreakNormal` in case consumers need to override a applied `word-break: break-all`
- Using the above class on props doc table contents to fix elastic#678
@cchaos cchaos added style only documentation Issues or PRs that only affect documentation - will not need changelog entries labels Aug 7, 2018
@cchaos cchaos requested review from chandlerprall and snide August 7, 2018 16:13
Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll defer to @snide to approve :)

Copy link
Copy Markdown
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this one. Was so annoying.

Comment thread CHANGELOG.md Outdated
- Added `repositionOnScroll` prop to `EuiPopover` which enables repositioning the popover when the window is scrolled. ([#1064](https://github.com/elastic/eui/pull/1064))
- Allow `_` and `*` characters to be used in `EuiSearchBar` query terms ([#1058](https://github.com/elastic/eui/pull/1058))
- Added more `status` options for `EuiSteps` ([#1088](https://github.com/elastic/eui/pull/1088))
- Added more `.eui-textBreakNormal` and `@mixin euiTextTruncate` as CSS/SASS utilities ([#1092](https://github.com/elastic/eui/pull/1092))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/pasta "more".

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe

@cchaos cchaos merged commit a9e584e into elastic:master Aug 7, 2018
@cchaos cchaos deleted the break-normal branch August 7, 2018 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issues or PRs that only affect documentation - will not need changelog entries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set nowrap on props definitions

3 participants