[EuiWrappingPopover] Do not re-mount button on componentWillUnmount if button has been unmounted from DOM#1114
Merged
Merged
Conversation
nreese
changed the title
nreese
force-pushed
the
wrappingPopover
branch
from
e38a07c to
18c3d1b
Compare
chandlerprall
approved these changes
Aug 13, 2018
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Change LGTM; I pulled and re-ran the docs for this component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in Kibana where the anchor element gets re-attached on
componentWillUnmounteven if the anchor element has been removed from the DOM.To see the bug in action, first open a dashboard in edit mode and click the
Optionstop nav button to open the Options popover.Then click the
Canceltop nav button (while the Options popover is still open). Dashboard will remove theOptionstop nav from the menu bar. but thencomponentWillUnmountwill add it back.It should look like this.
This PR only re-mounts the button component when it still has a parent (is attached to the DOM). I have tested this in Kibana and this fixes the problem shown above