Fix react-vis overrides#1123
Conversation
sorenlouv
left a comment
There was a problem hiding this comment.
Thanks for doing this! 🙏
|
FWIW @markov00, in the |
| return ( | ||
| <div {...rest}> | ||
| <div | ||
| className="euiSeriesChartContainer" |
There was a problem hiding this comment.
I think this is a fine way to do it (albeit, for now) since this container already exists and you don't need to then create classnames for each individual plot.
|
Oh and don't forget a changelog entry and double check your tests, I see the latest build errored. |
|
@cchaos sure, It's a bit strange why the test fails, when I ran the tests I've also got some other snapshot updated like @cchaos I can also change this to enable composition of external classnames together with the one on eui @jasonrhodes yes sure, the big problem with react-vis is that not every component has the possibility to pass a class, some of them have already some style applied that override your class so we preferred to import their scss files and change them directly. |
Fix #1121
On the current implementation we copied the existing
react-visstyle into EUI.We also overridden few classes.
Since react-vis is also used on APM, I've scoped all the
react-visclass behind a container class.BTW this is a workaround until the new version of the EUIChart is ready.