Merged
Conversation
snide
commented
Nov 7, 2017
| } | ||
| } | ||
|
|
||
| // if (this.props.sections.length > 1) { |
Contributor
Author
There was a problem hiding this comment.
@cjcenizal for now i've simply commented out the side nested items in the docs. We can add them back in with the new formatting later.
Contributor
Author
|
@formgeist I was able to apply the correct padding on the title icon versions in this PR. Should look pretty close to yours, minus the arrow coloring (which I'll address in a later PR). |
cjcenizal
approved these changes
Nov 7, 2017
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
Nice work! LGTM. I'll take a whack at this once it's merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces this PR #112
Closes #50 and https://github.com/elastic/Design/issues/647
This is a WIP Sidenav exploration. It needs some work on the React side before we can merge it, assuming people are OK with the style.
Changes the following:
EuiSideNavGroupis a new component for nesting a group ofEuiSideNavItems. It adds some borders and ticking to items underneath. It can be nested indefinitely (as space allows)EuiSideNavItemnow has aparentprop. This will render some arrow carets and other styling.EuiTitleinheritance inEuiSubNavTitleand just applied those styles directly in the CSS. Make the component more flexible so you can include icons and the like.Stuff to do before merge
EuiSideNavItemelement.Need help on the React side (will be a later PR)
EuiSideNavGroupneeds to wrap around subnav items in our actual documentation sidenav. I'll bug @cjcenizal about it, likely easy. Add back SideNav submenu in documentation #116