Skip to content

Sidenav tree cleanup#114

Merged
snide merged 9 commits intoelastic:masterfrom
snide:sidenav_cleanup
Nov 7, 2017
Merged

Sidenav tree cleanup#114
snide merged 9 commits intoelastic:masterfrom
snide:sidenav_cleanup

Conversation

@snide
Copy link
Contributor

@snide snide commented Nov 7, 2017

Replaces this PR #112

Closes #50 and https://github.com/elastic/Design/issues/647

This is a WIP Sidenav exploration. It needs some work on the React side before we can merge it, assuming people are OK with the style.

Changes the following:

  • EuiSideNavGroup is a new component for nesting a group of EuiSideNavItems. It adds some borders and ticking to items underneath. It can be nested indefinitely (as space allows)
  • EuiSideNavItem now has a parent prop. This will render some arrow carets and other styling.
  • Removing the EuiTitle inheritance in EuiSubNavTitle and just applied those styles directly in the CSS. Make the component more flexible so you can include icons and the like.

Stuff to do before merge

  • Play with focus state. It's a little weak.
  • Chat with CJ about how to pass icons in to the cloned EuiSideNavItem element.
  • Better document the new props / usage.
  • Fix sidenav in panel.

Need help on the React side (will be a later PR)

image

@snide snide mentioned this pull request Nov 7, 2017
6 tasks
@snide snide added breaking change PRs with breaking changes. (Don't delete - used for automation) design decision Use this to flag an item that needs input from the design team labels Nov 7, 2017
}
}

// if (this.props.sections.length > 1) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjcenizal for now i've simply commented out the side nested items in the docs. We can add them back in with the new formatting later.

@snide
Copy link
Contributor Author

snide commented Nov 7, 2017

@formgeist I was able to apply the correct padding on the title icon versions in this PR. Should look pretty close to yours, minus the arrow coloring (which I'll address in a later PR).

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM. I'll take a whack at this once it's merged.

@snide snide merged commit 34cef95 into elastic:master Nov 7, 2017
@snide snide deleted the sidenav_cleanup branch November 7, 2017 20:39
@snide snide mentioned this pull request Nov 7, 2017
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change PRs with breaking changes. (Don't delete - used for automation) design decision Use this to flag an item that needs input from the design team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants