Decorate pagination 'next' and 'previous' buttons with data-test-subj#1182
Merged
justinkambic merged 3 commits intoSep 11, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The purpose of this PR is to add
data-test-subjtoPagination's next and previous buttons. I have a number of functional tests expecting a table's pagination to have these values, and when I replaced the existing table witheuicomponents I got stuck. Link to those changes: elastic/kibana#22902Screens of the props rendered in the docs:
I chose these values based on the existing naming used for the numbered buttons, per https://github.com/elastic/eui/blob/master/src/components/pagination/pagination.js#L33
Checklist
Note: anything unchecked here I did not feel was applicable, please let me know if I need to revisit any items