Fixes select warning on falsy value in EuiSelect#1254
Merged
Conversation
cqliu1
changed the title
cqliu1
changed the title
Contributor
|
LGTM! TGIF |
chandlerprall
suggested changes
Oct 19, 2018
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
needs a bugfix changelog, then LGTM!
cqliu1
force-pushed
the
fix/select-value-check
branch
from
406f284 to
01d0a0c
Compare
Contributor
Author
|
@chandlerprall I added the bug fix to the changelog 👍 |
cqliu1
force-pushed
the
fix/select-value-check
branch
from
01d0a0c to
f524fb1
Compare
chandlerprall
approved these changes
Oct 19, 2018
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
LGTM, thanks @cqliu1 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I passed an empty string, 0 or false to the
valueprop in theEuiSelectcomponent, I would get this React warning:Warning: Select elements must be either controlled or uncontrolled (specify either the value prop, or the defaultValue prop, but not both). Decide between using a controlled or uncontrolled select element and remove one of these props. More info: https://fb.me/react-controlled-componentsBy switching from a falsy check to a check for null equality, these warnings no longer pop up for the falsy values.