Skip to content

Adds TypeScript definitions for EuiFieldPassword#1255

Merged
zumwalt merged 5 commits into
elastic:masterfrom
zumwalt:zumwalt/ts-defs-for-form-fields
Oct 23, 2018
Merged

Adds TypeScript definitions for EuiFieldPassword#1255
zumwalt merged 5 commits into
elastic:masterfrom
zumwalt:zumwalt/ts-defs-for-form-fields

Conversation

@zumwalt
Copy link
Copy Markdown
Contributor

@zumwalt zumwalt commented Oct 19, 2018

No description provided.

Comment thread src/components/form/field_password/index.d.ts Outdated
Co-Authored-By: zumwalt <casey@zumwa.lt>
Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more small change to enable that Ref usage, sorry!

Comment thread src/components/form/field_password/index.d.ts Outdated
Co-Authored-By: zumwalt <casey@zumwa.lt>
Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zumwalt !!

@zumwalt zumwalt merged commit 5ad3f5f into elastic:master Oct 23, 2018
@zumwalt zumwalt deleted the zumwalt/ts-defs-for-form-fields branch October 23, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants