Add TypeScript definitions for EuiConfirmModal#1260
Merged
Conversation
Plus numerous definition fixes
pugnascotia
force-pushed
the
revenge-of-the-ts-defs
branch
from
d66b0d1 to
01109f1
Compare
pugnascotia
changed the title
EuiConfirmModal and EuiFieldPasswordEuiConfirmModal
chandlerprall
suggested changes
Oct 24, 2018
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Looks great, only one change requested
Co-Authored-By: pugnascotia <roryhunter2@gmail.com>
Contributor
Author
|
@chandlerprall all updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TypeScript definitions for
EuiConfirmModal, plus other definition fixes.Notes:
AnyPropsdefinition to map toanyvalues, because I observed that the existing definition was too restrictive.EuiTableRowbecauseAnyPropswasn't necessary to allow e.g.keyordata-fooprops, and other table rows attributes are deprecated in HTML5.colorprop forEuiIconactually allows 6 or 3 digit hex color codes, so I allowedstringas a possible type. I left the existing values as documentation.