Adding APM trace icon#1263
Merged
Merged
Conversation
Adding a new icon for APM for “trace”
snide
approved these changes
Oct 25, 2018
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
Looks good. Minor cleanup for the CL. One note: most of our gylphs don't use "frames". I know it's hard for APM, so it's it's OK, but just thought I'd mention it, since I don't know your usage.
Co-Authored-By: formgeist <casper@formgeist.com>
Contributor
Author
|
@snide Thanks for the suggest and feedback. Good to know about the frames, didn't really think of it that way. I might return to make some changes to it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding a new icon for APM for “trace”.