Fixing highContrastTextColor sass function#1275
Merged
Merged
Conversation
The foreground is now adjusted based on the backgrounds brightness not the theme. It also includes fail safes to stop the `@while` from running if it reaches a certain lightness level (can’t lighten/darken any further).
snide
approved these changes
Oct 31, 2018
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
Nice. This is a great change.
We should add a CL for this, even though it's just the Sass layer.
Contributor
Author
|
Yep, whoops, forgot. I guess it's been a while.... |
ryankeairns
approved these changes
Oct 31, 2018
Contributor
ryankeairns
left a comment
ryankeairns
left a comment
There was a problem hiding this comment.
Without having poked around at the code, I had made the assumption it already worked in this manner. Expectations now meet reality which is a great place to be, nice enhancement :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The foreground is now adjusted based on the backgrounds brightness not the theme. It also includes fail safes to stop the
@whilefrom running if it reaches a certain lightness level (can’t lighten/darken any further).To test
Try changing any
tintOrShadeto justtintorshade.