Skip to content

Convert EuiExpression to TS#1368

Merged
cchaos merged 12 commits into
elastic:masterfrom
cchaos:ts-expression
Dec 14, 2018
Merged

Convert EuiExpression to TS#1368
cchaos merged 12 commits into
elastic:masterfrom
cchaos:ts-expression

Conversation

@cchaos
Copy link
Copy Markdown
Contributor

@cchaos cchaos commented Dec 12, 2018

No more EuiExpressionButton

The breaking change on this is that there were 2 components EuiExpression and EuiExpressionButton. EuiExpression did absolutely nothing but be a div wrapper. So I removed the EuiExpressionButton as the name was limiting and just made it EuiExpression.

More options

I also added more options to the EuiExpression:

  • color: for specifying the color of the description (defaults to 'success')
  • uppercase: for telling the component to or not to uppercase the description (defaults to true)
  • onClick: now this option forces the component to be a button with some styles associated with click-ability otherwise if a function is not provided it will be a "ready only" style.

I also changed the font family to our mono spaced font, and reduced some of the height for a more compressed look.

cc @nreese

screen shot 2018-12-12 at 14 17 49 pm


Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

@cchaos cchaos added breaking change PRs with breaking changes. (Don't delete - used for automation) typescript labels Dec 12, 2018
Comment thread src/components/expression/expression.tsx Outdated
Copy link
Copy Markdown
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor design questions, that I'm fine with either way. Looks a lot better.

Comment thread src/components/expression/expression.tsx
Comment thread src/components/expression/_expression.scss
Comment thread src-docs/src/views/card/card_beta.js
@cchaos cchaos merged commit 2f80577 into elastic:master Dec 14, 2018
@cchaos cchaos deleted the ts-expression branch December 14, 2018 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change PRs with breaking changes. (Don't delete - used for automation) typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants