Skip to content

if no selector on anchor, don't style in EuiText#1373

Merged
snide merged 2 commits into
elastic:masterfrom
snide:text/btn
Dec 14, 2018
Merged

if no selector on anchor, don't style in EuiText#1373
snide merged 2 commits into
elastic:masterfrom
snide:text/btn

Conversation

@snide
Copy link
Copy Markdown
Contributor

@snide snide commented Dec 14, 2018

Summary

Fixes #1372

I think this will work the way we expect EuiText to operate. If it's a regular anchor, pass on styling, but if it has a class, then ignore and use whatever it has. The assumption is that if you have a class on an anchor, you know how you want it styled.

image

image

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode
- [ ] Any props added have proper autodocs

  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
    - [ ] This was checked for breaking changes and labeled appropriately
    - [ ] Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
    - [ ] This required updates to Framer X components

@snide snide requested review from cchaos and cjcenizal December 14, 2018 00:03
Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution! Works as expected.

Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snide snide merged commit 8c54c17 into elastic:master Dec 14, 2018
@snide snide deleted the text/btn branch December 14, 2018 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants