Adds onFocus prop to EuiComboBox#1375
Merged
Merged
Conversation
zumwalt
commented
Dec 14, 2018
| options?: EuiComboBoxOptionsListProps['options'], | ||
| selectedOptions?: EuiComboBoxOptionsListProps['selectedOptions'], | ||
| onChange?: (options: Array<EuiComboBoxOptionProps>) => any, | ||
| onFocus?: () => any, |
Contributor
Author
There was a problem hiding this comment.
This feels wrong, but I wasn't sure if we should include something like InputHTMLAttributes to cover it.
chandlerprall
suggested changes
Dec 14, 2018
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Small change to handle the onFocus type def, otherwise great!
Co-Authored-By: zumwalt <casey@zumwa.lt>
Contributor
|
@zumwalt you also need to import |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR exposes
EuiComboBoxInput'sonFocusprop in theEuiComboBoxcomponent.Checklist
[ ] This was checked in mobile[ ] This was checked in IE11[ ] This was checked in dark mode[ ] Documentation examples were added[ ] This required updates to Framer X components