Skip to content

[EuiColorPicker] align color picker popup with color selector when page is scrolled#1397

Merged
nreese merged 2 commits into
elastic:masterfrom
nreese:color_picker_scroll
Dec 26, 2018
Merged

[EuiColorPicker] align color picker popup with color selector when page is scrolled#1397
nreese merged 2 commits into
elastic:masterfrom
nreese:color_picker_scroll

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Dec 26, 2018

Summary

Fixes #1394. Sets parent to relative so color picker popup stays with color selector element when scrolled

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@nreese nreese requested a review from snide December 26, 2018 15:20
Copy link
Copy Markdown
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and verified that this won't break anything.

@nreese nreese merged commit d8bd4e3 into elastic:master Dec 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants