Skip to content

Add inputRef prop to EuiFieldNumber and allow callbacks in select inputRef#1434

Merged
Bargs merged 4 commits into
elastic:masterfrom
Bargs:moreInputRefs
Jan 18, 2019
Merged

Add inputRef prop to EuiFieldNumber and allow callbacks in select inputRef#1434
Bargs merged 4 commits into
elastic:masterfrom
Bargs:moreInputRefs

Conversation

@Bargs
Copy link
Copy Markdown
Contributor

@Bargs Bargs commented Jan 14, 2019

Title says it all

Summary

Summarize your PR. If it includes design elements include a screenshot or gif.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@Bargs Bargs requested a review from chandlerprall January 14, 2019 23:23
Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a CHANGELOG entry

Comment thread src/components/form/field_number/index.d.ts Outdated
Comment thread src/components/form/select/index.d.ts Outdated
@Bargs Bargs self-assigned this Jan 15, 2019
@Bargs
Copy link
Copy Markdown
Contributor Author

Bargs commented Jan 17, 2019

@chandlerprall made the updates and added a changelog entry.

Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Bargs Bargs merged commit 1a0af58 into elastic:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants