Skip to content

Misc small fixes related to nav drawer#1448

Merged
ryankeairns merged 1 commit into
elastic:masterfrom
ryankeairns:rk/header-logo
Jan 17, 2019
Merged

Misc small fixes related to nav drawer#1448
ryankeairns merged 1 commit into
elastic:masterfrom
ryankeairns:rk/header-logo

Conversation

@ryankeairns
Copy link
Copy Markdown
Contributor

@ryankeairns ryankeairns commented Jan 17, 2019

Summary

A few miscellaneous fixes are combined in this PR:

  1. Forgot the CHANGELOG entry on my EuiNavDrawer PR Adds side nav component (EuiNavDrawer) #1427
  2. Discovered a misspell to a variable name
  3. Added more time to OutsideClickDetector to prevent it from immediately closing on mobile toggle
  4. Reduced padding on EuiHeaderLogo (used in Kibana) to align logo button with new nav width

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@ryankeairns ryankeairns merged commit 49ae8ec into elastic:master Jan 17, 2019
@snide snide mentioned this pull request Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants