Skip to content

Fix font stack for monospace font#1465

Merged
cchaos merged 2 commits into
elastic:masterfrom
cchaos:fix-monospace
Jan 23, 2019
Merged

Fix font stack for monospace font#1465
cchaos merged 2 commits into
elastic:masterfrom
cchaos:fix-monospace

Conversation

@cchaos
Copy link
Copy Markdown
Contributor

@cchaos cchaos commented Jan 23, 2019

@weltenwort Caught a bug during the assets build process that spit out the monospace font as:

"euiCodeFontFamily": "Roboto Mono Consolas Menlo 'courier', 'new' monospace",

This just removes new and fixes spacing issues to it now spits out as:

"euiCodeFontFamily": "'Roboto Mono', 'Consolas', 'Menlo', 'Courier', monospace",

Checklist

  • [ ] This was checked in mobile
  • [ ] This was checked in IE11
  • [ ] This was checked in dark mode
  • [ ] Any props added have proper autodocs
  • [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • [ ] This was checked for breaking changes and labeled appropriately
  • [ ] Jest tests were updated or added to match the most common scenarios
  • [ ] This was checked against keyboard-only and screenreader scenarios
  • [ ] This required updates to Framer X components

@cchaos cchaos added the bug label Jan 23, 2019
@cchaos cchaos requested review from chandlerprall and snide January 23, 2019 16:59
@cchaos cchaos merged commit d9ab789 into elastic:master Jan 23, 2019
@cchaos cchaos deleted the fix-monospace branch January 23, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants