[EuiSuperDatePicker] Add onRefresh handler#1577
Merged
Merged
Conversation
jasonrhodes
reviewed
Feb 20, 2019
jasonrhodes
reviewed
Feb 20, 2019
onRefresh handler (WIP)onRefresh handler
Contributor
Author
|
@nreese How do you suggest we document this feature? |
Contributor
@cchaos and @chandlerprall any thoughts on how best to document? |
Contributor
|
Move the EuiSuperDatePicker to it's own page and split up the examples to address all these edge cases. |
Contributor
Author
Is this a refactor of the EuiSuperDatePicker docs, or just for the new |
cchaos
reviewed
Feb 22, 2019
dc76393 to
61e73bf
Compare
nreese
reviewed
Feb 25, 2019
Contributor
Author
|
Feedback addressed. |
cchaos
approved these changes
Feb 25, 2019
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Thanks! There's just a few outstanding items in the PR checklist to cover, like a changelog entry.
1e528fa to
5e656ee
Compare
chandlerprall
suggested changes
Feb 25, 2019
chandlerprall
approved these changes
Feb 25, 2019
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting the refresh rate on
EuiSuperDatePickerit should keep track of the interval, and call theonRefreshhandler whenever the interval fires.This will save consumers the hassle of implementing this logic themselves.
Checklist