Added displayOnly prop to EuiFormRow#1582
Merged
Merged
Conversation
added 2 commits
February 21, 2019 11:27
And updated the form layout page docs with some snippets
da02952 to
ad1c421
Compare
Contributor
Author
|
cc @bevacqua |
Contributor
Author
|
@chandlerprall Any thoughts on why my changes would cause this in IE11? |
Contributor
Author
|
Ugh, I think I found it, stupid VS code auto-imported |
Contributor
|
Should |
Contributor
Author
|
We ran in circles a bit on this one and ultimately, it all |
Contributor
|
+1 to making it optional |
snide
approved these changes
Feb 21, 2019
Contributor
snide
left a comment
There was a problem hiding this comment.
Reviewed code, checked docs and display. All look good.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

...and updated the form layout page docs with some snippets.
Basically if you add the
displayOnlyprop, it will add a wrapper around the child and vertically center it.Checklist
[ ] This was checked in dark mode[ ] This was checked for breaking changes and labeled appropriately[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components