Upgrade typescript, react, jest, & enzyme#1583
Conversation
…pgrade React & ReactDOM to 16.8, upgrade enzyme & related libs to latest
pugnascotia
left a comment
There was a problem hiding this comment.
Looks fine for the most part. There's no CHANGELOG entry though.
How would you feel about replacing SFC with FunctionComponent throughout the codebase? The former is deprecated now (along with StatelessFunctionalComponent or whatever it is).
|
Thanks for the reminder! Have been looking forward to changing SFC -> FunctionalComponent |
|
Seeing an error on initial docs load:
Coming from the |
|
@pugnascotia converted SFC -> FunctionComponent |
pugnascotia
left a comment
There was a problem hiding this comment.
Still no CHANGELOG?
You have conflicts now too.
I'll changelog at the very end. I'd prefer merging this on its own release so less changes ship in the breaking change, and that means any changelog now will conflict then.
Updated! |
| @@ -2,7 +2,6 @@ import { CommonProps, Omit } from '../common'; | |||
| /// <reference path="../button/index.d.ts" /> | |||
| /// <reference path="../focus_trap/index.d.ts" /> | |||
|
|
|||
Summary
Closes #1383
This is a breaking change
None of the changes should have downstream effects but our minimum dependency versions have changed.
Kibana & Cloud have updated to React 16.8 and most recent @types/* libraries, this brings EUI up to date and continues supporting these projects the best we can.
getDerivedStateFromPropsimplementationstatic defaultPropsin class components.Checklist
- [ ] This was checked in mobile- [ ] This was checked in dark mode- [ ] Documentation examples were added- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components