Render <EuiProgress> as display block#166
Merged
bevacqua merged 4 commits intoelastic:masterfrom Nov 29, 2017
Merged
Conversation
Contributor
Author
|
Use https://github.com/elastic/eui/pull/166/files?w=1 to ignore the whitespace changes |
Contributor
|
Did a visual check. Looks like the fixed position one now adds the background color. Not the end of the world, but something I noticed. Might effect other places as well. Looks like it's only in Chrome. FF still behaves as it did before. Before, no gray bar
After, gray bar bg
|
Contributor
Author
|
Hadn't noticed that subtlety before. I'll get that solved. |
Contributor
Author
|
Fix is up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise it breaks layout. Cleaned up spacing, thus the diff looks bigger than what actually changed.