Converted EuiFormErrorText to TS#1772
Merged
Merged
Conversation
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Contributor
|
This is only a small part of the larger META ticket, so it doesn't need the |
Contributor
|
jenkins test this |
thompsongl
suggested changes
Mar 27, 2019
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Thanks!
Two changes to make:
src/components/form/form_error_text/index.d.tscan becomesrc/components/form/form_error_text/index.tssrc/components/form/form_error_text/index.jsshould then be deleted
Contributor
Author
|
@thompsongl I've updated the PR |
thompsongl
previously approved these changes
Mar 29, 2019
cchaos
changed the title
EuiFormErrorText to TSEuiFormErrorText to TS
thompsongl
suggested changes
Mar 29, 2019
added 7 commits
March 29, 2019 16:21
Contributor
Author
|
@thompsongl PR updated |
thompsongl
approved these changes
Mar 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As per #1557
Checklist