Converted EuiToolTipPopover to TS#1800
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@chandlerprall PR updated. Thanx |
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; Built eui.d.ts locally and verified EuiToolTip is exported as expected.
|
jenkins test this |
|
@theodesp merged, and thanks again! One suggestion - it looks like you're reusing your master branch for each of these, which creates an ever-increasing history on each of these PRs EUI enforces merge by squashing, which creates a single new commit for each PR and ignores the history of the commits during development. This means that the individual commits you make on your master branch are not part of the repo's history, only the single squash per PR, so when a new PR is created from your master branch git sees the whole history is different and flags all affected files, even though the majority of them have no differences between EUI master and your branch. Seeing a clean and focused commit history in a PR helps us correctly review; if you could pull your master to the latest eui/master that would help a lot; I'm not sure the "best" way to do this given the existing history on your fork's master, but personally I would delete your master branch and re-create it based on eui's master. I believe you could also merge eui/master into your master, or rebase yours against eui/master, which will end up in a few empty conflicts. Going forward, creating a new branch for each change set will help keep the history cleaner. |
|
I think If i delete my master and pull from eui will fix it. Then I will use feature branches that merge into eui master and when they are merged just sync my master with only from eui master without conflicts |

Summary
As per #1557
Checklist