Adds cut icon#1802
Merged
Merged
Conversation
ryankeairns
force-pushed
the
rk/add-cut-icon
branch
from
7d8b40f to
accdae6
Compare
snide
approved these changes
Apr 5, 2019
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
Tested locally. Surprised how sharp it looks. usually the diagonal ones get pixelly.
Contributor
|
Should we name it "scissors"? The thing that it is not what it represents. I think that's how we've been doing it, with a few outliers. I'm fine either way, just wanted to put it out there. |
Contributor
|
I thought the same initially, then figured people would look for "cut" like they do "copy". I could similarly go either way. |
Co-Authored-By: ryankeairns <rkeairns@chef.io>
Contributor
Author
|
The literal naming is a good path to continue following, however this one seems to fit into the outlier group as it predates modern civilization 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Canvas provides a standard cut capability for elements on a workpad. We have plans to use this in a context menu for element templates. This PR also alphabetizes a couple of icons that were out of order.
Preview
Sketch screenshot
Similar to other tool-style icons (e.g. copy and copyClipboard), this icon uses the full 16x16 space.
Checklist
This was checked in mobileAny props added have proper autodocsThis was checked for breaking changes and labeled appropriatelyThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components