Add an invalid state to EuiSuperSelect#1804
Merged
Merged
Conversation
cchaos
suggested changes
Apr 8, 2019
Contributor
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
invalid={isInvalid} should be applied to the hidden input
cchaos
reviewed
Apr 8, 2019
cjcenizal
approved these changes
Apr 8, 2019
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Tested locally, code LGTM! I'm not familiar enough with the role of the invalid prop to provide an opinion so I'll let you all hash it out... though it doe seem odd that we're using an HTML attribute that doesn't seem to exist. What happens if we remove that? Maybe it was originally a mistake?
Contributor
Author
|
@cjcenizal Yep. We resolved. @cchaos should be ready. Removed that HTML bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1460
Sorry for the slow response on this one @cjcenizal. Must have come in on a busy day. Saw it when cleaning our backlog and was an easy enough fix.
Checklist
This was checked in mobileThis was checked in IE11This was checked for breaking changes and labeled appropriatelyThis was checked against keyboard-only and screenreader scenariosThis required updates to Framer X components