Skip to content

EuiOverlayMask converted to TS#1858

Merged
thompsongl merged 4 commits into
elastic:masterfrom
theodesp:task/EuiOverlayMask-to-TS
Apr 24, 2019
Merged

EuiOverlayMask converted to TS#1858
thompsongl merged 4 commits into
elastic:masterfrom
theodesp:task/EuiOverlayMask-to-TS

Conversation

@theodesp
Copy link
Copy Markdown
Contributor

@theodesp theodesp commented Apr 19, 2019

Summary

Converted EuiOverlayMask to TS

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@theodesp theodesp force-pushed the task/EuiOverlayMask-to-TS branch from 8dc1218 to 68396df Compare April 19, 2019 09:45
Comment thread src/components/overlay_mask/overlay_mask.tsx Outdated
@theodesp theodesp force-pushed the task/EuiOverlayMask-to-TS branch from 68396df to 965765f Compare April 23, 2019 10:48
@theodesp
Copy link
Copy Markdown
Contributor Author

@chandlerprall I have updated my PR. Ta

Copy link
Copy Markdown
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM

@thompsongl
Copy link
Copy Markdown
Contributor

jenkins test this

@theodesp
Copy link
Copy Markdown
Contributor Author

@thompsongl conflicts resolved

@thompsongl
Copy link
Copy Markdown
Contributor

jenkins test this

@thompsongl thompsongl merged commit 2d0ac3b into elastic:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants