Skip to content

token_map converted to TS#1870

Merged
thompsongl merged 4 commits into
elastic:masterfrom
theodesp:task/tokenMap-to-TS
Apr 25, 2019
Merged

token_map converted to TS#1870
thompsongl merged 4 commits into
elastic:masterfrom
theodesp:task/tokenMap-to-TS

Conversation

@theodesp
Copy link
Copy Markdown
Contributor

@theodesp theodesp commented Apr 23, 2019

Summary

Converted token_map to TS

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Copy Markdown
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Comment thread src/components/token/token_map.ts Outdated
Comment thread src/components/token/token_map.ts
Comment thread src/components/token/token_map.ts Outdated
@theodesp theodesp force-pushed the task/tokenMap-to-TS branch from 25febeb to 9ba2dfc Compare April 24, 2019 16:16
@thompsongl
Copy link
Copy Markdown
Contributor

jenkins test this

Comment thread src/components/token/index.d.ts Outdated
@theodesp
Copy link
Copy Markdown
Contributor Author

pr updated

@thompsongl
Copy link
Copy Markdown
Contributor

Appreciate the help, @theodesp 🙌

jenkins test this

Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built eui.d.ts locally, exported values look good

@thompsongl thompsongl merged commit c151fd7 into elastic:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants