Skip to content

EuiValidatableControl convert to TS#1879

Merged
thompsongl merged 4 commits into
elastic:masterfrom
theodesp:task/validatable-control-to-TS
May 1, 2019
Merged

EuiValidatableControl convert to TS#1879
thompsongl merged 4 commits into
elastic:masterfrom
theodesp:task/validatable-control-to-TS

Conversation

@theodesp
Copy link
Copy Markdown
Contributor

@theodesp theodesp commented Apr 24, 2019

Summary

EuiValidatableControl converted to TS

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Apr 24, 2019

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@chandlerprall chandlerprall self-requested a review April 24, 2019 16:03
@chandlerprall chandlerprall mentioned this pull request Apr 25, 2019
Merged
10 tasks
chandlerprall
chandlerprall suggested changes Apr 26, 2019
View reviewed changes
Comment thread src/components/form/validatable_control/validatable_control.tsx Outdated
Comment thread src/components/form/validatable_control/validatable_control.tsx Outdated
Comment thread src/components/form/validatable_control/validatable_control.tsx Outdated
Comment thread src/components/form/validatable_control/validatable_control.tsx Outdated
Comment thread src/components/form/validatable_control/validatable_control.tsx Outdated
@theodesp theodesp force-pushed the task/validatable-control-to-TS branch from 9f371a2 to 17e219b Compare April 30, 2019 08:09
@theodesp
Copy link
Copy Markdown
Contributor Author

theodesp commented Apr 30, 2019

@chandlerprall Pr updated

chandlerprall
chandlerprall approved these changes Apr 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM; built and tested eui.d.ts locally

@theodesp
Copy link
Copy Markdown
Contributor Author

theodesp commented May 1, 2019

@chandlerprall Conflicts resolved

@thompsongl thompsongl merged commit 2505c6d into elastic:master May 1, 2019
@chandlerprall chandlerprall mentioned this pull request May 2, 2019
Merged
1 task
@theodesp theodesp deleted the task/validatable-control-to-TS branch May 29, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chandlerprall chandlerprall chandlerprall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theodesp @elasticmachine @chandlerprall @thompsongl