Skip to content

Allowing the last item in the breadcrumbs to be clickable.#1905

Merged
daveyholler merged 7 commits into
elastic:masterfrom
daveyholler:breadcrumb-link
May 1, 2019
Merged

Allowing the last item in the breadcrumbs to be clickable.#1905
daveyholler merged 7 commits into
elastic:masterfrom
daveyholler:breadcrumb-link

Conversation

@daveyholler
Copy link
Copy Markdown
Contributor

Summary

The last item in the breadcrumbs will now be clickable if an href is provided.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

Copy link
Copy Markdown
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm, thanks fo doing that. Just had a couple copy suggestions.

Comment thread CHANGELOG.md Outdated
Comment thread src-docs/src/views/breadcrumbs/breadcrumbs_example.js Outdated
daveyholler and others added 3 commits May 1, 2019 11:14
Co-Authored-By: daveyholler <daveyholler@gmail.com>
Co-Authored-By: daveyholler <daveyholler@gmail.com>
Comment thread CHANGELOG.md Outdated
@daveyholler daveyholler merged commit 9ac2229 into elastic:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants