Add K6 overrides and more advanced theming system#191
Merged
snide merged 12 commits intoelastic:masterfrom Dec 12, 2017
Merged
Conversation
5 tasks
cjcenizal
approved these changes
Dec 11, 2017
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
One comment. This PR needs a rebase and a note in the CHANGELOG that we've adding two new themes, and then I think we're good to merge!
src/global_styling/k6/_index.scss
Outdated
| @@ -0,0 +1,2 @@ | |||
| // @import 'size'; | |||
Contributor
There was a problem hiding this comment.
Can we delete this line?
Contributor
Author
|
@cjcenizal I rearranged how we import sass in regards to themes. Wanted to contain themes to their own directory vs having the files spread out in each folder that needed it. Also went ahead and wrote up docs for how to make themes. Give it another look, then we should be OK to merge. |
cjcenizal
approved these changes
Dec 12, 2017
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
LGTM! Let's merge this and cut a new release!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By providing a K6 theme over the K7 components, we're hoping to enable Kibana engineers to consume this framework today, while retaining a consistent look-and-feel in the Kibana UI.
Guidelines
K6 theme
The K6 theme consists of: