Skip to content

Creating new CSS class: euiFlexGroup--justifyContentSpaceEvenly#205

Merged
ycombinator merged 2 commits intoelastic:masterfrom
ycombinator:flex-group/justify-content/add-option
Dec 14, 2017
Merged

Creating new CSS class: euiFlexGroup--justifyContentSpaceEvenly#205
ycombinator merged 2 commits intoelastic:masterfrom
ycombinator:flex-group/justify-content/add-option

Conversation

@ycombinator
Copy link
Contributor

This PR:

  • Adds a new euiFlexGroup--justifyContentSpaceEvenly CSS class
  • Adds corresponding spaceEvenly option to justifyContent prop on the EuiFlexGroup component
  • Updates the corresponding Jest snapshot to cover the new option
  • Adds corresponding documentation
  • Adds CHANGELOG item

@ycombinator ycombinator changed the title [EuiFlexGroup] Creating new CSS class euiFlexGroup--justifyContentSpaceEvenly Creating new CSS class euiFlexGroup--justifyContentSpaceEvenly Dec 14, 2017
@ycombinator ycombinator changed the title Creating new CSS class euiFlexGroup--justifyContentSpaceEvenly Creating new CSS class: euiFlexGroup--justifyContentSpaceEvenly Dec 14, 2017
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 LGTM! One minor comment. Thanks for this!

CHANGELOG.md Outdated
@@ -1,6 +1,7 @@
# [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `0.0.5`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you delete this line?

@ycombinator ycombinator merged commit f8d7882 into elastic:master Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants