Apply additional props to checkbox/switch inputs rather than wrappers#246
Merged
snide merged 2 commits intoelastic:masterfrom Jan 2, 2018
Merged
Apply additional props to checkbox/switch inputs rather than wrappers#246snide merged 2 commits intoelastic:masterfrom
snide merged 2 commits intoelastic:masterfrom
Conversation
Contributor
|
@snide Thanks for making this change. It's a good improvement. Would you mind moving the changelog note to the "breaking changes" section since this technically changes the effects these props have upon this component? |
Contributor
Author
|
@cjcenizal will do. |
snide
added
the
breaking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225
Passes
{rest}onto the inputs themselves rather than the wrappers. Ran some quick tests to make sure we weren't using those props against the wrappers. This is how we pass it to our text based inputs as well.