Proper classname for flexGroup alignItems prop#257
Merged
snide merged 3 commits intoelastic:masterfrom Jan 3, 2018
Merged
Conversation
nreese
approved these changes
Jan 3, 2018
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
lgtm, don't forget to update the change log
nreese
reviewed
Jan 3, 2018
CHANGELOG.md
Outdated
| **Bug fixes** | ||
|
|
||
| - Clicking the downArrow icon in `EuiSelect` now triggers selection. [(#237)[https://github.com/elastic/eui/pull/255]] | ||
| - Proper classname for flexGroup alignItems prop. [(#256)[https://github.com/elastic/eui/pull/256]] |
Contributor
There was a problem hiding this comment.
I think you used the wrong PR number. This PR is 257
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class being used in the component was not the one being used in the sass. This uses the proper one used in the sass. Since the css is not effected, this is a non-breaking change.