Preserve contextMenuItem onClick event handler argument#265
Merged
weltenwort merged 1 commit intoelastic:masterfrom Jan 8, 2018
Merged
Preserve contextMenuItem onClick event handler argument#265weltenwort merged 1 commit intoelastic:masterfrom
weltenwort merged 1 commit intoelastic:masterfrom
Conversation
This change preserves the `onClick` handler's signature of `<T>(event: React.MouseEvent<T>) => void` even if a `panel` is given. Additionally, the event will be removed from the React event pooling system due to the async nature of the `requestAnimationFrame` callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change preserves the
onClickhandler's signature of<T>(event: React.MouseEvent<T>) => voideven if apanelis given. Additionally, the event will be removed from the React event pooling system due to the async nature of therequestAnimationFramecallback.